[webkit-changes] [WebKit/WebKit] fd7fe1: Clean up handling of background-position shorthand...

Tim Nguyen noreply at github.com
Mon Nov 14 01:37:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd7fe182b10d940000b88d4ec01f5a33e62df99e
      https://github.com/WebKit/WebKit/commit/fd7fe182b10d940000b88d4ec01f5a33e62df99e
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M LayoutTests/fast/css/remove-shorthand-expected.txt
    M Source/WebCore/css/StyleProperties.cpp

  Log Message:
  -----------
  Clean up handling of background-position shorthand in StyleProperties::asTextInternal()
https://bugs.webkit.org/show_bug.cgi?id=247879
rdar://102306296

Reviewed by Antti Koivisto.

The old code was collapsing background-position-x/y into background-position.
It is not needed anymore, as returning true in canUseShorthandForLonghand for background-position has the same effect.

Test: fast/css/background-position-serialize.html

* LayoutTests/fast/css/remove-shorthand-expected.txt:
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::canUseShorthandForLonghand):
(WebCore::StyleProperties::asTextInternal const):

Canonical link: https://commits.webkit.org/256643@main




More information about the webkit-changes mailing list