[webkit-changes] [WebKit/WebKit] 056c2a: Make sure nested worker get controlled if matching...

youennf noreply at github.com
Mon Nov 14 00:25:56 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 056c2a9cad9c31deb641fcb7ca0d8e1291d92e8c
      https://github.com/WebKit/WebKit/commit/056c2a9cad9c31deb641fcb7ca0d8e1291d92e8c
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/nested-blob-url-workers.https-expected.txt
    M Source/WebCore/workers/WorkerScriptLoader.cpp
    M Source/WebCore/workers/WorkerScriptLoader.h
    M Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp

  Log Message:
  -----------
  Make sure nested worker get controlled if matching a service worker registration
https://bugs.webkit.org/show_bug.cgi?id=247619
rdar://problem/102090425

Reviewed by Chris Dumez.

Allow to register WorkerScriptLoader living of the main thread (nested workers do create them).
Instead of registering a WorkerScriptLoader*, we now register a callback which is called when we need to set a worker as controlled.
Covered by unskipped test.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/nested-blob-url-workers.https-expected.txt: Added.
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::workerScriptLoaderControlledCallbackMap):
(WebCore::accessWorkerScriptLoaderMap):
(WebCore::WorkerScriptLoader::~WorkerScriptLoader):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::getWorkerClientControlledCallback):
(): Deleted.
(WebCore::WorkerScriptLoader::fromScriptExecutionContextIdentifier): Deleted.
* Source/WebCore/workers/WorkerScriptLoader.h:
* Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::setServiceWorkerClientIsControlled):

Canonical link: https://commits.webkit.org/256637@main




More information about the webkit-changes mailing list