[webkit-changes] [WebKit/WebKit] f2e73e: Grid track sizing should reset the override width ...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2e73e71c88c14822ac5f6d077634fc828ad686e
      https://github.com/WebKit/WebKit/commit/f2e73e71c88c14822ac5f6d077634fc828ad686e
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    A LayoutTests/fast/dynamic/relayout-grid-should-reset-instrinsic-sizes-expected.html
    A LayoutTests/fast/dynamic/relayout-grid-should-reset-instrinsic-sizes.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  Grid track sizing should reset the override width as well as height to compute intrinsic sizing.
https://bugs.webkit.org/show_bug.cgi?id=247465
<rdar://101304306>

Reviewed by Alan Baradlay.

Grid layout (sometimes) sets the override content size and containing block sizes, so that grid items get sized relative to their grid tracks, rather than the size of the grid element.

During the sizing process, we want to know the intrinsic size of children, so we reset any overrides and re-layout children to measure them.

We're currently not resetting the content logical width, and there's a comment saying that grid never uses it, but that's out of date and we do need to reset this.

* LayoutTests/fast/dynamic/relayout-grid-should-reset-instrinsic-sizes-expected.html: Added.
* LayoutTests/fast/dynamic/relayout-grid-should-reset-instrinsic-sizes.html: Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
* Source/WebCore/rendering/RenderGrid.cpp:

Canonical link: https://commits.webkit.org/256622@main