[webkit-changes] [WebKit/WebKit] d44b5d: Crash in FormData::flatten

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d44b5de990f9926f252451908f71528d37e681da
      https://github.com/WebKit/WebKit/commit/d44b5de990f9926f252451908f71528d37e681da
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-11-12 (Sat, 12 Nov 2022)

  Changed paths:
    A LayoutTests/fast/forms/submit-form-dialog-crash-expected.txt
    A LayoutTests/fast/forms/submit-form-dialog-crash.html
    M Source/WebCore/loader/FormSubmission.cpp

  Log Message:
  -----------
  Crash in FormData::flatten
https://bugs.webkit.org/show_bug.cgi?id=247652

Reviewed by Youenn Fablet.

The bug was caused by FormSubmission::requestURL assuming that the method is GET
if it's not POST, and trying to serialize the form data as the URL query string.

Fixed the bug by adding method type check.

* LayoutTests/fast/forms/submit-form-dialog-crash-expected.txt: Added.
* LayoutTests/fast/forms/submit-form-dialog-crash.html: Added.
* Source/WebCore/loader/FormSubmission.cpp:
(WebCore::FormSubmission::requestURL const):

Canonical link: https://commits.webkit.org/256613@main