[webkit-changes] [WebKit/WebKit] bc1d07: Setting -webkit-column-count to auto is the same a...

Ahmad Saleem noreply at github.com
Sat Nov 12 11:34:20 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc1d0765c50f1b0d7e2c8aeaf31b24cb2a9bd8d8
      https://github.com/WebKit/WebKit/commit/bc1d0765c50f1b0d7e2c8aeaf31b24cb2a9bd8d8
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-11-12 (Sat, 12 Nov 2022)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.h

  Log Message:
  -----------
  Setting -webkit-column-count to auto is the same as not setting it

Setting -webkit-column-count to auto is the same as not setting it
https://bugs.webkit.org/show_bug.cgi?id=247745

Reviewed by Alan Baradlay.

Merge - https://chromium.googlesource.com/chromium/blink/+/da85d1a90375fe50a92cf46f8a49571850618294

In RenderStyle, column-count is represented by two members, one integer
specifying the count, and one bool specifying whether it's auto or not. If
column-count is auto, the integer is ignored, but if the integer changes, it's
still detected as a style change (even if auto is set to true), and we'll mark
for layout for no good reason. Make sure that setting column-count to auto also
resets the integer to its initial value, to avoid this problem.

* Source/WebCore/rendering/style/RenderStyle.h: Update "setHasAutoColumnCount" to return "initialColumnCount" rather than "0"

Canonical link: https://commits.webkit.org/256607@main




More information about the webkit-changes mailing list