[webkit-changes] [WebKit/WebKit] af4bfb: Don't detach whitespace nodes when the previous si...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af4bfb1cdbf87b2c7f020cd627ea2d72177fee26
      https://github.com/WebKit/WebKit/commit/af4bfb1cdbf87b2c7f020cd627ea2d72177fee26
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-11-12 (Sat, 12 Nov 2022)

  Changed paths:
    M LayoutTests/fast/block/positioning/relative-positioned-inline-container-expected.txt
    A LayoutTests/fast/inline/do-not-detach-whitespace-with-out-of-flow-siblings-inside-inline-parent-expected.html
    A LayoutTests/fast/inline/do-not-detach-whitespace-with-out-of-flow-siblings-inside-inline-parent.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-007-expected.txt
    M LayoutTests/platform/glib/fast/block/positioning/052-expected.txt
    M LayoutTests/platform/glib/fast/block/positioning/058-expected.txt
    M LayoutTests/platform/glib/fast/block/positioning/relative-positioned-inline-container-expected.txt
    M LayoutTests/platform/glib/fast/block/positioning/trailing-space-test-expected.txt
    M LayoutTests/platform/gtk/fast/block/positioning/052-expected.png
    M LayoutTests/platform/gtk/fast/block/positioning/058-expected.png
    M LayoutTests/platform/gtk/fast/block/positioning/rtl-static-positioning-expected.txt
    M LayoutTests/platform/gtk/fast/block/positioning/trailing-space-test-expected.png
    M LayoutTests/platform/ios/fast/block/positioning/052-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/058-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/rtl-static-positioning-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/trailing-space-test-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/052-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/058-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/trailing-space-test-expected.txt
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Don't detach whitespace nodes when the previous sibling is an out of flow block

Don't detach whitespace nodes when the previous sibling is an out of flow block
https://bugs.webkit.org/show_bug.cgi?id=247683

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?revision=195585&view=revision

A whitespace node was not being rendered after an out of flow block element was
inserted in front of it and the container was an inline element. Normally a
block element would cause the whitespace node to be detached as it should no
longer be rendered since the block element creates a new line. This doesn't
matter though if the block element is out of the normal flow of the document.
Now we correctly verify that the inserted block element is in the normal flow
the document before deciding if no renderer is needed.

* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(RenderTreeUpdater::textRendererIsNeeded): Add "isOutOfFlowPositioned" condition
* LayoutTests/fast/inline/do-not-detach-whitespace-with-out-of-flow-siblings-inside-inline-parent.html: Add Test Case
* LayoutTests/fast/inline/do-not-detach-whitespace-with-out-of-flow-siblings-inside-inline-parent-expected.html: Add Test Case Expectation
* LayoutTests/fast/block/positioning/relative-positioned-inline-container-expected.txt: Updated Test Expectations
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-007.txt: Ditto
* LayoutTests/platform/glib/fast/block/positioning/052-expected.txt: Ditto
* LayoutTests/platform/glib/fast/block/positioning/058-expected.txt: Ditto
* LayoutTests/platform/glib/fast/block/positioning/relative-positioned-inline-container-expected.txt: Ditto
* LayoutTests/platform/glib/fast/block/positioning/trailing-space-test-expected.txt: Ditto
* LayoutTests/platform/gtk/fast/block/positioning/052-expected.png: Ditto
* LayoutTests/platform/gtk/fast/block/positioning/058-expected.png: Ditto
* LayoutTests/platform/gtk/fast/block/positioning/rtl-static-positioning-expected.txt: Ditto
* LayoutTests/platform/gtk/fast/block/positioning/trailing-space-test-expected.png: Ditto
* LayoutTests/platform/ios/fast/block/positioning/052-expected.txt: Ditto
* LayoutTests/platform/ios/fast/block/positioning/058-expected.txt: Ditto
* LayoutTests/platform/ios/fast/block/positioning/rtl-static-positioning-expected.txt: Ditto
* LayoutTests/platform/ios/fast/block/positioning/trailing-space-test-expected.txt: Ditto
* LayoutTests/platform/mac/fast/block/positioning/052-expected.txt: Ditto
* LayoutTests/platform/mac/fast/block/positioning/058-expected.txt: Ditto
* LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Ditto
* LayoutTests/platform/mac/fast/block/positioning/trailing-space-test-expected.txt: Ditto

Canonical link: https://commits.webkit.org/256602@main