[webkit-changes] [WebKit/WebKit] da821c: setting selectorText fails when passed a selector ...

Darin Adler noreply at github.com
Fri Nov 11 19:09:33 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da821c38176a14cc22d0195fb8a45489d55defc6
      https://github.com/WebKit/WebKit/commit/da821c38176a14cc22d0195fb8a45489d55defc6
  Author: Darin Adler <darin at apple.com>
  Date:   2022-11-11 (Fri, 11 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleRule-set-selectorText-namespace-expected.txt
    M Source/WebCore/css/CSSPageRule.cpp
    M Source/WebCore/css/CSSStyleRule.cpp
    M Source/WebCore/css/parser/CSSParser.cpp
    M Source/WebCore/css/parser/CSSParser.h

  Log Message:
  -----------
  setting selectorText fails when passed a selector that includes namespace prefixes
https://bugs.webkit.org/show_bug.cgi?id=247830
rdar://problem/102260326

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleRule-set-selectorText-namespace-expected.txt:
Expect PASS.

* Source/WebCore/css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText): Pass the style sheet in.
* Source/WebCore/css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText): Ditto.
* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSelector): Pass the style sheet along.
* Source/WebCore/css/parser/CSSParser.h: Take an optional style sheet.

Canonical link: https://commits.webkit.org/256599@main




More information about the webkit-changes mailing list