[webkit-changes] [WebKit/WebKit] b37371: Revert [252611 at main] Align XHR aborting with the s...

Chris Dumez noreply at github.com
Fri Nov 11 13:10:33 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b37371177a8cb1150db551c272cbe13384471090
      https://github.com/WebKit/WebKit/commit/b37371177a8cb1150db551c272cbe13384471090
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-11-11 (Fri, 11 Nov 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/tests/navigation/page-cache-xhr-expected.txt
    M LayoutTests/http/tests/navigation/page-cache-xhr.html
    M LayoutTests/http/tests/navigation/resources/page-cache-xhr-in-loading-iframe.html
    M LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt
    M LayoutTests/http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt
    M LayoutTests/http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt
    M LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt
    M LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html
    M LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt
    M LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_wildcard-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_multi-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_null-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_origin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_origin_uppercase-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_space-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_wildcard-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_zero-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/xhr/abort-after-stop.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/xhr/open-after-stop.window-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt
    M LayoutTests/platform/mac-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    M LayoutTests/platform/win/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt
    M LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/xml/XMLHttpRequest.cpp
    M Source/WebCore/xml/XMLHttpRequest.h

  Log Message:
  -----------
  Revert [252611 at main] Align XHR aborting with the specification and other browser engines
https://bugs.webkit.org/show_bug.cgi?id=242817
rdar://101617443

Unreviewed, revert 252611 at main as it broke the Capital One app.

* LayoutTests/TestExpectations:
* LayoutTests/http/tests/navigation/page-cache-xhr-expected.txt:
* LayoutTests/http/tests/navigation/page-cache-xhr.html:
* LayoutTests/http/tests/navigation/resources/page-cache-xhr-in-loading-iframe.html:
* LayoutTests/http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt:
* LayoutTests/http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
* LayoutTests/http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt:
* LayoutTests/http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
* LayoutTests/http/tests/xmlhttprequest/navigation-should-abort.html:
* LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt:
* LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_wildcard-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_multi-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_null-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_origin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_origin_uppercase-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_space-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_wildcard-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resource-timing/resource_TAO_zero-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/xhr/abort-after-stop.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/xhr/open-after-stop.window-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
* LayoutTests/platform/win/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
* LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestFromDelegate):
(WebCore::FrameLoader::blockedError const):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didFail):
* Source/WebCore/xml/XMLHttpRequest.h:

Canonical link: https://commits.webkit.org/256586@main




More information about the webkit-changes mailing list