[webkit-changes] [WebKit/WebKit] 8db7eb: New test: [iOS] TestWebKitAPI.ServiceWorker.Extens...

Chris Dumez noreply at github.com
Thu Nov 10 16:09:52 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8db7eb4f9596f35be583e73747d9f2fd16f87ac8
      https://github.com/WebKit/WebKit/commit/8db7eb4f9596f35be583e73747d9f2fd16f87ac8
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-11-10 (Thu, 10 Nov 2022)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm

  Log Message:
  -----------
  New test: [iOS] TestWebKitAPI.ServiceWorker.ExtensionServiceWorkerDisableCORS is frequently timing out
https://bugs.webkit.org/show_bug.cgi?id=247757
rdar://102206729

Reviewed by Geoffrey Garen.

All tests in this files were calling [ServiceWorkerSchemeHandler addMappingFromURLString:]
with a string literal. As a result, this function has an optimization to avoid copying
(& freeing) the passed-in string.

However, the new ServiceWorker.ExtensionServiceWorkerDisableCORS is passing a dynamically
generated String and this optimization is thus no longer safe.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerSchemeHandler addMappingFromURLString:toData:]):

Canonical link: https://commits.webkit.org/256553@main




More information about the webkit-changes mailing list