[webkit-changes] [WebKit/WebKit] 72b68e: [ macOS wk2 ] imported/w3c/web-platform-tests/perm...

Chris Dumez noreply at github.com
Thu Nov 10 15:21:13 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72b68e3da33f8d73d5aa7385426b1215d202778f
      https://github.com/WebKit/WebKit/commit/72b68e3da33f8d73d5aa7385426b1215d202778f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-11-10 (Thu, 10 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/permissions/permissions-cg.https.html
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  [ macOS wk2 ] imported/w3c/web-platform-tests/permissions/permissions-cg.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=245802
rdar://100530413

Reviewed by Geoffrey Garen.

Make sure the PermissionStatus object gets constructed and its `change` event
listener gets registered *BEFORE* we update the permission state. Previously,
the order wasn't guaranteed and this would lead to flakiness because the `change`
would get fired before the event listener got added.

Also trigger garbage collection explicitly to make it more likely to trigger
GC bugs, given that this is what the test intends to cover.

* LayoutTests/imported/w3c/web-platform-tests/permissions/permissions-cg.https.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/256550@main




More information about the webkit-changes mailing list