[webkit-changes] [WebKit/WebKit] cbf750: AX: VoiceOver highlight does not move to Shadow DO...
EWS
noreply at github.com
Thu Nov 10 06:06:45 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cbf7509a12dfb20efcf128f99ea2788f92622526
https://github.com/WebKit/WebKit/commit/cbf7509a12dfb20efcf128f99ea2788f92622526
Author: Tommy McHugh <thomas_mchugh at apple.com>
Date: 2022-11-10 (Thu, 10 Nov 2022)
Changed paths:
A LayoutTests/accessibility/shadow-dom-element-in-aria-modal-expected.txt
A LayoutTests/accessibility/shadow-dom-element-in-aria-modal.html
M Source/WebCore/accessibility/AccessibilityObject.cpp
Log Message:
-----------
AX: VoiceOver highlight does not move to Shadow DOM button when using aria-modal and role
https://bugs.webkit.org/show_bug.cgi?id=247134
rdar://problem/101637934
Reviewed by Andres Gonzalez.
AccessibilityObject::isModalDescendant eroneuously returned false for shadow hosts
inside the modal because the template code is outside the modal. This patch fixes
that by using Node::isDescendantOrShadowDescendantOf to properly consider shadow DOM elements.
* LayoutTests/accessibility/shadow-dom-element-in-aria-modal-expected.txt: Added.
* LayoutTests/accessibility/shadow-dom-element-in-aria-modal.html: Added.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isModalDescendant const):
Canonical link: https://commits.webkit.org/256531@main
More information about the webkit-changes
mailing list