[webkit-changes] [WebKit/WebKit] f05061: WebSocket requests should include Sec-Fetch-Mode=w...

youennf noreply at github.com
Thu Nov 10 04:25:51 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f05061a1e8307f802de0f4f17059ae8a6dee58d9
      https://github.com/WebKit/WebKit/commit/f05061a1e8307f802de0f4f17059ae8a6dee58d9
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-11-10 (Thu, 10 Nov 2022)

  Changed paths:
    A LayoutTests/http/wpt/fetch/fetch-metadata-websocket-expected.txt
    A LayoutTests/http/wpt/fetch/fetch-metadata-websocket.html
    A LayoutTests/platform/mac-bigsur/http/wpt/fetch/fetch-metadata-websocket-expected.txt
    A LayoutTests/platform/win/http/wpt/fetch/fetch-metadata-websocket-expected.txt
    M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp

  Log Message:
  -----------
  WebSocket requests should include Sec-Fetch-Mode=websocket for FetchMetadata
https://bugs.webkit.org/show_bug.cgi?id=237550
rdar://problem/90106854

Reviewed by Alex Christensen.

Add Sec Fetch headers to the WebSocket Handshake request.
We specila case this since we do not have a good use of websocket destination and mode enumeration values.
And the URL needs to be translated from ws to http scheme.

Add win and bigsur expectations since they do not support custom HTTP headers.

* LayoutTests/platform/win/http/wpt/fetch/fetch-metadata-websocket-expected.txt:
* LayoutTests/platform/mac-bigsur/http/wpt/fetch:
* LayoutTests/http/wpt/fetch/fetch-metadata-websocket-expected.txt: Added.
* LayoutTests/http/wpt/fetch/fetch-metadata-websocket.html: Added.
* Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest):

Canonical link: https://commits.webkit.org/256527@main




More information about the webkit-changes mailing list