[webkit-changes] [WebKit/WebKit] 3d4ebd: Ensure AddAllowedFirstPartyForCookies message is p...

EWS noreply at github.com
Wed Nov 9 10:34:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d4ebd0d31cdcbb0984e106d0acb8130e5007071
      https://github.com/WebKit/WebKit/commit/3d4ebd0d31cdcbb0984e106d0acb8130e5007071
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    A LayoutTests/platform/gtk/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

  Log Message:
  -----------
  Ensure AddAllowedFirstPartyForCookies message is processed before ScheduleResourceLoad
https://bugs.webkit.org/show_bug.cgi?id=247582
rdar://102056030

Reviewed by Chris Dumez.

The API test ProcessSwap.NavigateCrossSiteBeforePageLoadEnd was so sensitive to the reordering of messages
that it started failing, so I made it respond asynchronously to give the network process time to respond
to these new roundtrip messages.  Otherwise, no change in behavior.  It's taking something that's async
and adding an async step.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::addAllowedFirstPartyForCookies):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
* Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::createContextConnection):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):

Canonical link: https://commits.webkit.org/256488@main




More information about the webkit-changes mailing list