[webkit-changes] [WebKit/WebKit] f8b2bf: [WPE][GTK] Implement `background-repeat: space` us...

Vitaly Dyachkov noreply at github.com
Wed Nov 9 06:53:31 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8b2bfb13b8381e180c9591f15cc783e36bc1644
      https://github.com/WebKit/WebKit/commit/f8b2bfb13b8381e180c9591f15cc783e36bc1644
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M LayoutTests/platform/gtk/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
    M Source/WebCore/platform/graphics/cairo/CairoOperations.h
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.h
    M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
    M Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp

  Log Message:
  -----------
  [WPE][GTK] Implement `background-repeat: space` using cairo.
https://bugs.webkit.org/show_bug.cgi?id=120596

Drawing a repeating background in cairo is done by creating a pattern
from the background image and then extending it.

When `background-repeat` property is set to `space`, cairo drawing
routine is provided with the calculated spacing value that must be
applied while extending the pattern.

Unfortunately, cairo doesn't support extending a pattern beyond its
boundaries. To achieve a similar effect we create a temporary pattern
that incorporates the original image and the spacing and then extend it.

Reviewed by Carlos Garcia Campos.

* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawPattern):
* Source/WebCore/platform/graphics/cairo/CairoOperations.h:
* Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext):
* Source/WebCore/platform/graphics/cairo/CairoUtilities.h:
* Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContextCairo::drawPattern):
* Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawPattern):

Canonical link: https://commits.webkit.org/256484@main




More information about the webkit-changes mailing list