[webkit-changes] [WebKit/WebKit] c96806: Always push the colorspace into IOSurface metadata

Simon Fraser noreply at github.com
Tue Nov 8 21:45:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c968064ecdab458363753d6d6e4df0a63042076b
      https://github.com/WebKit/WebKit/commit/c968064ecdab458363753d6d6e4df0a63042076b
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-11-08 (Tue, 08 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Source/WebCore/platform/graphics/cocoa/IOSurface.h
    M Source/WebCore/platform/graphics/cocoa/IOSurface.mm

  Log Message:
  -----------
  Always push the colorspace into IOSurface metadata
https://bugs.webkit.org/show_bug.cgi?id=247603
rdar://102074507

Reviewed by Tim Horton.

The colorspace argument to IOSurface constructors is currently only used by the CGContext creation
code, except for WebGL which pushes it into IOSurface metadata.

With UI-side compositing on macOS, it's important that the IOSurface colorspace information
survives the trip between processes, so we might as well always push it into IOSurface
metadata.

* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::allocateAndBindDisplayBufferBacking):
* Source/WebCore/platform/graphics/cocoa/IOSurface.h:
* Source/WebCore/platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::IOSurface):
(WebCore::IOSurface::setColorSpaceProperty):
(WebCore::IOSurface::migrateColorSpaceToProperties): Deleted.

Canonical link: https://commits.webkit.org/256477@main




More information about the webkit-changes mailing list