[webkit-changes] [WebKit/WebKit] e04540: unhelpful error message for TableGrow
EWS
noreply at github.com
Tue Nov 8 18:33:02 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e04540b26853a7d9396cd0a60b09c8babf8ca289
https://github.com/WebKit/WebKit/commit/e04540b26853a7d9396cd0a60b09c8babf8ca289
Author: David Degazio <d_degazio at apple.com>
Date: 2022-11-08 (Tue, 08 Nov 2022)
Changed paths:
M Source/JavaScriptCore/wasm/WasmFunctionParser.h
M Source/JavaScriptCore/wasm/WasmTypeDefinition.h
M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py
Log Message:
-----------
unhelpful error message for TableGrow
https://bugs.webkit.org/show_bug.cgi?id=247452
rdar://101241285
Reviewed by Justin Michaud and Yusuke Suzuki.
Improves our error messages when printing WebAssembly types. Instead of printing just the TypeKind,
the WasmFunctionParser now prints the type itself, and instead of Wasm::Type::dump printing the TypeKind,
it now prints the TypeDefinition or more-specific TypeKind if available.
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseStructFieldManipulation):
(JSC::Wasm::FunctionParser<Context>::checkBranchTarget):
(JSC::Wasm::FunctionParser<Context>::unify):
(JSC::Wasm::FunctionParser<Context>::parseExpression):
* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
(JSC::Wasm::Type::dump const):
* Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:
Canonical link: https://commits.webkit.org/256472@main
More information about the webkit-changes
mailing list