[webkit-changes] [WebKit/WebKit] 052d5b: onorientationchange and orientation attributes mus...

Darin Adler noreply at github.com
Tue Nov 8 17:00:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 052d5b6a2ca083a096c425d601b79b95c98d6ac8
      https://github.com/WebKit/WebKit/commit/052d5b6a2ca083a096c425d601b79b95c98d6ac8
  Author: Darin Adler <darin at apple.com>
  Date:   2022-11-08 (Tue, 08 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/compat/idlharness.window-expected.txt
    M Source/WebCore/html/HTMLBodyElement+Compat.idl
    M Source/WebCore/page/DOMWindow+Compat.idl
    M Source/WebCore/page/DOMWindow.cpp
    M Source/WebCore/page/DOMWindow.h

  Log Message:
  -----------
  onorientationchange and orientation attributes must be present unconditionally even on platforms without orientation change
https://bugs.webkit.org/show_bug.cgi?id=247646
rdar://problem/102110117

Reviewed by Chris Dumez.

* LayoutTests/imported/w3c/web-platform-tests/compat/idlharness.window-expected.txt:
Expect more PASS.

* Source/WebCore/html/HTMLBodyElement+Compat.idl: Remove the ORIENTATION_EVENTS conditional.
* Source/WebCore/page/DOMWindow+Compat.idl: Ditto.

* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::orientation const): Compile unconditionally, return 0 for
!ENABLE(ORIENTATION_EVENTS).

* Source/WebCore/page/DOMWindow.h: Remote conditional around orientation function.

Canonical link: https://commits.webkit.org/256469@main




More information about the webkit-changes mailing list