[webkit-changes] [WebKit/WebKit] 882a38: In M1 Ventura safari 16.1, when the constraints pa...
youennf
noreply at github.com
Tue Nov 8 12:29:41 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 882a38ecdaf1712c1415cdbbe39cdb6c075eb021
https://github.com/WebKit/WebKit/commit/882a38ecdaf1712c1415cdbbe39cdb6c075eb021
Author: Youenn Fablet <youennf at gmail.com>
Date: 2022-11-08 (Tue, 08 Nov 2022)
Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
Log Message:
-----------
In M1 Ventura safari 16.1, when the constraints passed in by getDisplayMedia contain the 'ideal' parameter, screen sharing will fail.
https://bugs.webkit.org/show_bug.cgi?id=247310
rdar://problem/101819966
Reviewed by Eric Carlson.
The issue is that the intrinsic size computation is wrong in GPUProcess.
This leads to a max size of (0, 0), which is used in case ideal constraints are used.
Instead of using CGDisplayCopyDisplayMode, we use getShareableContentWithCompletionHandler API which does not need any change to the sandbox.
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::intrinsicSize const):
Canonical link: https://commits.webkit.org/256458@main
More information about the webkit-changes
mailing list