[webkit-changes] [WebKit/WebKit] 92afb2: Fix SVG currentcolor resolution

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92afb29672fbc265024897612b6b4e944a811f84
      https://github.com/WebKit/WebKit/commit/92afb29672fbc265024897612b6b4e944a811f84
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2022-11-08 (Tue, 08 Nov 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt
    R LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png
    R LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt
    R LayoutTests/platform/ios/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt
    R LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png
    R LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt
    R LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
    R LayoutTests/svg/W3C-SVG-1.1/color-prop-05-t-w3c.png
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  Fix SVG currentcolor resolution
https://bugs.webkit.org/show_bug.cgi?id=227219

Reviewed by Sam Weinig and Darin Adler.

The currentcolor value for fill/stroke properties
has to be resolved at use-time,
not at builder (setter) time.

Remove duplicated color-prop-05-t test.

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt:
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt:
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt:
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt:
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt:
* LayoutTests/platform/ios/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/color-prop-05-t-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fallback-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-fill-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/painting/currentColor-override-pserver-stroke-expected.txt:
* LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
* LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
* LayoutTests/svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Removed.
* LayoutTests/svg/W3C-SVG-1.1/color-prop-05-t-w3c.png: Removed.
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::colorAndSVGPaintType):

Canonical link: https://commits.webkit.org/256447@main