[webkit-changes] [WebKit/WebKit] fc20b7: The size of a video track's settings is incorrect ...
Eric Carlson
noreply at github.com
Mon Nov 7 17:17:05 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc20b78a56dcc355e091918cd8e9e2e7981e00a3
https://github.com/WebKit/WebKit/commit/fc20b78a56dcc355e091918cd8e9e2e7981e00a3
Author: Eric Carlson <eric.carlson at apple.com>
Date: 2022-11-07 (Mon, 07 Nov 2022)
Changed paths:
A LayoutTests/fast/mediastream/cloned-video-stream-aspect-ratio-expected.txt
A LayoutTests/fast/mediastream/cloned-video-stream-aspect-ratio.html
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoSource.h
Log Message:
-----------
The size of a video track's settings is incorrect in the second MediaStream created when the 'aspectRatio' contraint is applied
https://bugs.webkit.org/show_bug.cgi?id=245511
rdar://100254156
Reviewed by Youenn Fablet.
* LayoutTests/fast/mediastream/cloned-video-stream-aspect-ratio-expected.txt: Added.
* LayoutTests/fast/mediastream/cloned-video-stream-aspect-ratio.html: Added.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::size const): Apply aspectRatio to size.
(WebCore::RealtimeMediaSource::setAspectRatio): Call `setSize` instead of modifying m_size
directly so observers will know the size has changed.
* Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::settingsDidChange): Call setSizeAndFrameRate when size changes
so settings are updated.
* Source/WebCore/platform/mediastream/RealtimeVideoSource.h:
Canonical link: https://commits.webkit.org/256433@main
More information about the webkit-changes
mailing list