[webkit-changes] [WebKit/WebKit] 82deae: Crash when displaying autofill buttons

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82deae87c0accda42971d92fe2e85d763fdf4e20
      https://github.com/WebKit/WebKit/commit/82deae87c0accda42971d92fe2e85d763fdf4e20
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    R LayoutTests/fast/forms/auto-fill-button/show-auto-fill-button-while-selection-inside-field-expected.txt
    R LayoutTests/fast/forms/auto-fill-button/show-auto-fill-button-while-selection-inside-field.html
    M Source/WebCore/html/HTMLTextFormControlElement.h
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/TextFieldInputType.h

  Log Message:
  -----------
  Crash when displaying autofill buttons
https://bugs.webkit.org/show_bug.cgi?id=247589
rdar://101938935

Reviewed by Wenson Hsieh.

Speculative revert of 255229 at main, as crashes have been observed when using
autofill buttons, following that change.

An alternate approach will need to be taken to fix webkit.org/b/245976.

* LayoutTests/fast/forms/auto-fill-button/show-auto-fill-button-while-selection-inside-field-expected.txt: Removed.
* LayoutTests/fast/forms/auto-fill-button/show-auto-fill-button-while-selection-inside-field.html: Removed.
* Source/WebCore/html/HTMLTextFormControlElement.h:
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::TextFieldInputType::createContainer):
* Source/WebCore/html/TextFieldInputType.h:

Canonical link: https://commits.webkit.org/256431@main