[webkit-changes] [WebKit/WebKit] cf442d: [Cocoa] Mac Catalyst builds don't correctly replac...

Patrick Angle noreply at github.com
Mon Nov 7 11:53:44 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf442de8dfd0db8743997344098054ddd962157b
      https://github.com/WebKit/WebKit/commit/cf442de8dfd0db8743997344098054ddd962157b
  Author: Patrick Angle <pangle at apple.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M Source/JavaScriptCore/Scripts/postprocess-header-rule
    M Source/WebKit/Scripts/postprocess-header-rule

  Log Message:
  -----------
  [Cocoa] Mac Catalyst builds don't correctly replace JS_IOS_TBA/WK_IOS_TBA in headers
https://bugs.webkit.org/show_bug.cgi?id=247516
rdar://101889288

Reviewed by Elliott Williams.

Currently on Mac Catalyst we replace JS_IOS_TBA/WK_IOS_TBA with "NA" instead of a real version number. For Catalyst
builds `LLVM_TARGET_TRIPLE_OS_VERSION` will contain the iOS version number we need. We also need to use the
`PLATFORM_NAME` and not the `WK_PLATFORM_NAME` for WebKit in order to replace the macOS version placeholder correctly,
since `WK_PLATFORM_NAME` will be `maccatalyst` for Catalyst, but we want to replace the Mac placeholder for all Mac
build styles, even Catalyst. We can then use the `WK_PLATFORM_NAME` as part of determining if we are building for
Catalyst.

* Source/JavaScriptCore/Scripts/postprocess-header-rule:
* Source/WebKit/Scripts/postprocess-header-rule:

Canonical link: https://commits.webkit.org/256419@main




More information about the webkit-changes mailing list