[webkit-changes] [WebKit/WebKit] c284b6: RemoteAudioMediaStreamTrackRendererInternalUnitMan...
Kimmo Kinnunen
noreply at github.com
Mon Nov 7 08:05:03 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c284b6bcb90b0ebdd77f590d3781c82198bb85c4
https://github.com/WebKit/WebKit/commit/c284b6bcb90b0ebdd77f590d3781c82198bb85c4
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2022-11-07 (Mon, 07 Nov 2022)
Changed paths:
M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp
Log Message:
-----------
RemoteAudioMediaStreamTrackRendererInternalUnitManager should ensure the stream is PCM audio
https://bugs.webkit.org/show_bug.cgi?id=247566
rdar://100552637
Reviewed by Youenn Fablet.
Make the stream track renderer unit use the audio description that the local unit
expects instead of trusting the one that WP sent as the ring buffer parameter.
These should match, but WP might send an invalid one. Since the data is used
in mixing, spoofed bytes per frame would cause buffer overwrites.
* Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::startUnit):
Canonical link: https://commits.webkit.org/256405@main
More information about the webkit-changes
mailing list