[webkit-changes] [WebKit/WebKit] 051a04: [GTK][WPE] Stop using injected bundle messages for...

Carlos Garcia Campos noreply at github.com
Mon Nov 7 01:14:09 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 051a04847864264224bafaea77cf12c5b185782f
      https://github.com/WebKit/WebKit/commit/051a04847864264224bafaea77cf12c5b185782f
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesWPE.txt
    M Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp
    A Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.cpp
    A Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebResourcePrivate.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
    M Source/WebKit/UIProcess/API/wpe/APIViewClient.h
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp
    M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h
    M Source/WebKit/UIProcess/API/wpe/WPEView.cpp
    M Source/WebKit/UIProcess/API/wpe/WPEView.h
    M Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/glib/WebPageProxyGLib.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp

  Log Message:
  -----------
  [GTK][WPE] Stop using injected bundle messages for implementing resource loader API
https://bugs.webkit.org/show_bug.cgi?id=245070

Reviewed by Michael Catanzaro.

Use WebPageProxy messages instead of injected bundle messages for GLib
resources loader API implementation. Also deprecate
WebKitWebResource::data-received signal, since I haven't found any app
using it and it increases the IPC traffic.

* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp:
(webkit_web_resource_class_init):
(webkitWebResourceSentRequest):
(webkitWebResourceSetResponse):
(webkitWebResourceFinished):
(webkitWebResourceFailed):
(webkitWebResourceNotifyProgress): Deleted.
(webkitWebResourceFailedWithTLSErrors): Deleted.
(webkitWebResourceGetFrame): Deleted.
* Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.cpp: Added.
(WebKit::WebKitWebResourceLoadManager::WebKitWebResourceLoadManager):
(WebKit::WebKitWebResourceLoadManager::~WebKitWebResourceLoadManager):
(WebKit::WebKitWebResourceLoadManager::didInitiateLoad):
(WebKit::WebKitWebResourceLoadManager::didSendRequest):
(WebKit::WebKitWebResourceLoadManager::didReceiveResponse):
(WebKit::WebKitWebResourceLoadManager::didFinishLoad):
* Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.h: Added.
* Source/WebKit/UIProcess/API/glib/WebKitWebResourcePrivate.h:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(WebKitWebViewClient::webResourceLoadManager):
(webkitWebViewConstructed):
(webkitWebViewLoadChanged):
(webkitWebViewGetWebResourceLoadManager):
(webkitWebViewResourceLoadStarted):
(webkitWebViewGetLoadingWebResource): Deleted.
(webkitWebViewRemoveLoadingWebResource): Deleted.
* Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h:
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::webResourceLoadManager):
* Source/WebKit/UIProcess/API/gtk/PageClientImpl.h:
* Source/WebKit/UIProcess/API/wpe/APIViewClient.h:
(API::ViewClient::webResourceLoadManager):
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::webResourceLoadManager):
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
* Source/WebKit/UIProcess/API/wpe/WPEView.cpp:
(WKWPE::View::webResourceLoadManager):
* Source/WebKit/UIProcess/API/wpe/WPEView.h:
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/glib/WebPageProxyGLib.cpp:
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::didFinishLoadForResource):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
(testWebResourceLoading):
(testWebResourceSendRequest):

Canonical link: https://commits.webkit.org/256388@main




More information about the webkit-changes mailing list