[webkit-changes] [WebKit/WebKit] 4718fa: Normalize style in makeprop.pl's output to aid rep...

Sam Weinig noreply at github.com
Sun Nov 6 13:47:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4718faa509f327097a30847ee21ede844aff6670
      https://github.com/WebKit/WebKit/commit/4718faa509f327097a30847ee21ede844aff6670
  Author: Sam Weinig <weinig at apple.com>
  Date:   2022-11-06 (Sun, 06 Nov 2022)

  Changed paths:
    M Source/WebCore/css/makeprop.pl

  Log Message:
  -----------
  Normalize style in makeprop.pl's output to aid replacing it
https://bugs.webkit.org/show_bug.cgi?id=247550
rdar://102015817

Reviewed by Darin Adler.

To make replacing makeprop.pl easier in https://bugs.webkit.org/show_bug.cgi?id=247470
this updates the generated output to consistently use the following stylist choices:

- Always use fully scoped name for CSSPropertyIDs (this will also make it a bit
easier to move to a scoped enum at some point).
- Use the parameter name "id" for CSSPropertyID parameters in generated functions.
- Move all the fullly static function bodies generated for CSSPropertyNames.gperf to
be consecutive.
- Add a missing space in the static part of isInheritedPropertyTable so that all
the true's look the same.

* Source/WebCore/css/makeprop.pl:
(generateFillLayerPropertyValueSetter):
(generateValueSetter):

Canonical link: https://commits.webkit.org/256379@main




More information about the webkit-changes mailing list