[webkit-changes] [WebKit/WebKit] ade47b: AX: Render tree continuations can cause parts of t...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ade47b72cbb4deea234467f294a13edcf496102f
      https://github.com/WebKit/WebKit/commit/ade47b72cbb4deea234467f294a13edcf496102f
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: Render tree continuations can cause parts of the AX tree to be duplicated
https://bugs.webkit.org/show_bug.cgi?id=247350
rdar://101506601

Reviewed by Chris Fleizach.

We partially solved this in https://bugs.webkit.org/show_bug.cgi?id=157818,
but that change isn't enough to prevent the problem in all cases because
it was scoped too narrowly — only skipping the computed next sibling if
`m_renderer` had a parent with an inline continuation.

With this patch, we now skip any computed nextSibling when it has the
same non-null node as `m_renderer`.

Despite many attempts, I wasn't able to construct a testcase for this one,
but I have manually confirmed that the bug is fixed.

* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::nextSibling const):

Canonical link: https://commits.webkit.org/256363@main