[webkit-changes] [WebKit/WebKit] ce48d3: [LFC][IFC] Do not consult root box's geometry in l...

Alan Baradlay noreply at github.com
Sat Nov 5 10:01:28 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce48d377e88259976e9363ed3658929a776f6c69
      https://github.com/WebKit/WebKit/commit/ce48d377e88259976e9363ed3658929a776f6c69
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/FormattingConstraints.h
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h
    M Source/WebCore/layout/formattingContexts/table/TableFormattingConstraints.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [LFC][IFC] Do not consult root box's geometry in line layout
https://bugs.webkit.org/show_bug.cgi?id=247521

Reviewed by Antti Koivisto.

Use the passed in constrain (horizontal) values instead -expand the constraints context with visual left to be able to compute rtl content offset.
(This is in preparation for not mutating the root box's geometry with logical values.)

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::build const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h:

Canonical link: https://commits.webkit.org/256355@main




More information about the webkit-changes mailing list