[webkit-changes] [WebKit/WebKit] e4f004: CRASH: Assertion in WPT /webvtt/rendering/cues-wit...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4f004bdfd57761fb70a5a2f80026d05e021fbe8
      https://github.com/WebKit/WebKit/commit/e4f004bdfd57761fb70a5a2f80026d05e021fbe8
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  CRASH: Assertion in WPT /webvtt/rendering/cues-with-video/processing-model/regions/viewportanchor_y_50_percent.html
https://bugs.webkit.org/show_bug.cgi?id=247333
rdar://100892574

Reviewed by Eric Carlson.

An existing check protects HTMLMediaElement::configureTextTrackDisplay() from making script-exposed changes while a
Document and it's ActiveDOMObjects has been stopped, but also needs to protect when those same objects are Suspended.

Re-use HTMLMediaElement::isSuspended() (which encompasses both those above checks) everywhere within HTMLMediaElement.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::exitFullscreen):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):

Canonical link: https://commits.webkit.org/256352@main