[webkit-changes] [WebKit/WebKit] 31968b: [WebXR] Use typed GL object helpers
Dan Glastonbury
noreply at github.com
Fri Nov 4 18:12:10 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 31968b06266f78b64623bcfb667dfbd4063c101f
https://github.com/WebKit/WebKit/commit/31968b06266f78b64623bcfb667dfbd4063c101f
Author: Dan Glastonbury <djg at apple.com>
Date: 2022-11-04 (Fri, 04 Nov 2022)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
M Source/WebCore/platform/graphics/GraphicsContextGL.h
M Source/WebCore/platform/graphics/GraphicsTypesGL.h
Log Message:
-----------
[WebXR] Use typed GL object helpers
https://bugs.webkit.org/show_bug.cgi?id=246977
rdar://101522082
Reviewed by Dean Jackson.
Replace generic OwnedGLObject with typed helpers that know how to create and
delete themselves. Since OpenGL object id's can be respecified, reset() is
replaced by ensure(), which ensures that an object id has been allocated.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
(WebCore::GCGLOwned::operator PlatformGLObject const):
(WebCore::GCGLOwned::~GCGLOwned):
* Source/WebCore/platform/graphics/GraphicsTypesGL.h:
(OwnedGLObject::OwnedGLObject): Deleted.
(OwnedGLObject::~OwnedGLObject): Deleted.
(OwnedGLObject::operator PlatformGLObject const): Deleted.
(OwnedGLObject::reset): Deleted.
(OwnedGLObject::release): Deleted.
Canonical link: https://commits.webkit.org/256347@main
More information about the webkit-changes
mailing list