[webkit-changes] [WebKit/WebKit] c46be5: WebDriver: [Cocoa] Regression(255359 at main) Excepti...

[Patrick Angle]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c46be5c1183bb2076c4996fd4528e6c638fc5a91
      https://github.com/WebKit/WebKit/commit/c46be5c1183bb2076c4996fd4528e6c638fc5a91
  Author: Patrick Angle <pangle at apple.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  WebDriver: [Cocoa] Regression(255359 at main) Exception when deleting remote automation session
https://bugs.webkit.org/show_bug.cgi?id=247384
rdar://101872145

Reviewed by Wenson Hsieh.

Revert the changes in 255359 at main and instead apply a more targeted approach to fixing that specific issue. Previous
attempts to fix this with more state management in `WKWindowVisibilityObserver` created more issues, so a more targeted
fix it is!

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(-[WKWindowVisibilityObserver startObserving:]):
(-[WKWindowVisibilityObserver stopObserving:]):
(WebKit::WebViewImpl::viewWillMoveToWindowImpl):
(WebKit::WebViewImpl::viewWillMoveToWindow):
(WebKit::WebViewImpl::prepareForMoveToWindow):
(-[WKWindowVisibilityObserver _observeWindow:]): Deleted.

Canonical link: https://commits.webkit.org/256334@main