[webkit-changes] [WebKit/WebKit] ad03a7: REGRESSION (iOS 16): <optgroup> labels are duplicated

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad03a719b1d933e3df519c9323b77dab9b417f3b
      https://github.com/WebKit/WebKit/commit/ad03a719b1d933e3df519c9323b77dab9b417f3b
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm

  Log Message:
  -----------
  REGRESSION (iOS 16): <optgroup> labels are duplicated
https://bugs.webkit.org/show_bug.cgi?id=247443
rdar://101241715

Reviewed by Wenson Hsieh.

WebKit displays <optgroup> elements as inline submenus. Prior to iOS 16, UIKit
did not display titles for inline submenus. Consequently, WebKit inserted a
disabled menu item at the top of each submenu, containing the <optgroup>'s
label.

However, UIKit began displaying titles for submenus in iOS 16, resulting in
duplicate labels. To fix, remove the labels added by WebKit.

* Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker createMenu]):
(-[WKSelectPicker actionForOptionIndex:]):

Canonical link: https://commits.webkit.org/256324@main