[webkit-changes] [WebKit/WebKit] 582343: Rename randomNumber to cryptographicallyRandomUnit...

Don Olmstead noreply at github.com
Thu Nov 3 21:45:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58234376adf2c562f9a7e4b626b115fbfac4e722
      https://github.com/WebKit/WebKit/commit/58234376adf2c562f9a7e4b626b115fbfac4e722
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M Source/WTF/wtf/RandomNumber.cpp
    M Source/WTF/wtf/RandomNumber.h
    M Source/WebCore/Modules/cache/CacheStorageConnection.cpp
    M Source/WebCore/Modules/mediastream/MediaDevices.cpp
    M Source/WebCore/loader/PrivateClickMeasurement.cpp
    M Source/WebCore/page/DOMTimer.cpp
    M Source/WebCore/page/DiagnosticLoggingClient.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
    M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
    M Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp
    M Tools/TestWebKitAPI/Tests/WTF/StdLibExtras.cpp

  Log Message:
  -----------
  Rename randomNumber to cryptographicallyRandomUnitInterval
https://bugs.webkit.org/show_bug.cgi?id=247469

Reviewed by Yusuke Suzuki.

Generating a cryptographically random number is significantly more
costly than generating a weakly random one. A function with the name
`randomNumber` is more likely to be used for run of the mill
applications than one whose name starts with `cryptographicallyRandom`.
Also make the name more specific so it communicates the actual range of
values returned, [0, 1] is the unit interval.

* Source/WTF/wtf/RandomNumber.cpp:
* Source/WTF/wtf/RandomNumber.h:
* Source/WebCore/Modules/cache/CacheStorageConnection.cpp:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
* Source/WebCore/loader/PrivateClickMeasurement.cpp:
* Source/WebCore/page/DOMTimer.cpp:
* Source/WebCore/page/DiagnosticLoggingClient.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
* Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
* Tools/TestWebKitAPI/Tests/WTF/StdLibExtras.cpp:

Canonical link: https://commits.webkit.org/256308@main




More information about the webkit-changes mailing list