[webkit-changes] [WebKit/WebKit] e43d0d: JetStream driver should ignore references to URL p...

hysu noreply at github.com
Thu Nov 3 17:58:18 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e43d0d6df74818c72e9270a1cc01e25c747c3545
      https://github.com/WebKit/WebKit/commit/e43d0d6df74818c72e9270a1cc01e25c747c3545
  Author: Hysu Xiong <hysu at apple.com>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M PerformanceTests/JetStream2/JetStreamDriver.js
    M PerformanceTests/JetStream3/JetStreamDriver.js

  Log Message:
  -----------
  JetStream driver should ignore references to URL parameters when run in `jsc` shell
https://bugs.webkit.org/show_bug.cgi?id=247460
rdar://101934826

Reviewed by Dewei Zhu.

Fix for JS2 tests in `jsc` shell (and also RAMification) being broken due to https://bugs.webkit.org/show_bug.cgi?id=247301
`URLSearchParams` is undefined in the `jsc` shell. But when run in the shell, URL parameters are irrelevant anyways so ideally they should be ignored.
  - Set default values for whether to report test results (false) and which specific subtests to run (empty list, or run all tests by default).
  - Check if `URLSearchParams` is defined, and if it is, override default reporting/subtest values with the ones specified.

* PerformanceTests/JetStream2/JetStreamDriver.js:
(typeof):
(Driver.prototype.async initialize):
(Driver.prototype.async reportScoreToRunBenchmarkRunner):
(prototype.else):
* PerformanceTests/JetStream3/JetStreamDriver.js:
(typeof):
(Driver.prototype.async initialize):
(Driver.prototype.async reportScoreToRunBenchmarkRunner):
(prototype.else):

Canonical link: https://commits.webkit.org/256304@main




More information about the webkit-changes mailing list