[webkit-changes] [WebKit/WebKit] 4de7fd: Assertion failure in RenderView::decrementRendersW...

Ryosuke Niwa noreply at github.com
Thu Nov 3 15:57:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4de7fdb96ff3e83b848e4b4f9d9296c9a87f6029
      https://github.com/WebKit/WebKit/commit/4de7fdb96ff3e83b848e4b4f9d9296c9a87f6029
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    A LayoutTests/fast/css/outline-display-table-crash-expected.txt
    A LayoutTests/fast/css/outline-display-table-crash.html
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  Assertion failure in RenderView::decrementRendersWithOutline
https://bugs.webkit.org/show_bug.cgi?id=247453

Reviewed by Simon Fraser.

The bug was caused by RenderElement::willBeDestroyed always calling decrementRendersWithOutline
regardless of whether the style had been initialized or not.

Only call decrementRendersWithOutline when the style had been initialized.

* LayoutTests/fast/css/outline-display-table-crash-expected.txt: Added.
* LayoutTests/fast/css/outline-display-table-crash.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeDestroyed):

Canonical link: https://commits.webkit.org/256297@main




More information about the webkit-changes mailing list