[webkit-changes] [WebKit/WebKit] 8c10d1: Fix -Wformat errors in logs added in 256087 at main

Don Olmstead noreply at github.com
Thu Nov 3 12:10:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c10d15cd232274843ecd412eb707b2a29c3b031
      https://github.com/WebKit/WebKit/commit/8c10d15cd232274843ecd412eb707b2a29c3b031
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/Platform/IPC/Connection.h

  Log Message:
  -----------
  Fix -Wformat errors in logs added in 256087 at main
https://bugs.webkit.org/show_bug.cgi?id=247376

Reviewed by Alex Christensen.

Clang 15 reports the error : using 'public' format specifier annotation
outside of os_log()/os_trace() [-Werror,-Wformat]. Use
`PUBLIC_LOG_STRING` which will expand to `public` when `USE(OS_LOG)` to
preserve behavior.

Also add a space between `__FILE__` and `ADD_QUOTES` for readability.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
* Source/WebKit/Platform/IPC/Connection.h:

Canonical link: https://commits.webkit.org/256283@main




More information about the webkit-changes mailing list