[webkit-changes] [WebKit/WebKit] 4e3531: Implement input validation for CSSColorValues

Chris Dumez noreply at github.com
Wed Nov 2 07:43:19 PDT 2022 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e3531dd8b179697e87ed54b0a601b4f4118629b
      https://github.com/WebKit/WebKit/commit/4e3531dd8b179697e87ed54b0a601b4f4118629b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-11-02 (Wed, 02 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/resources/testhelper.js
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab.html
    M Source/WebCore/css/typedom/color/CSSColorValue.cpp
    M Source/WebCore/css/typedom/color/CSSColorValue.h
    M Source/WebCore/css/typedom/color/CSSHSL.cpp
    M Source/WebCore/css/typedom/color/CSSHSL.h
    M Source/WebCore/css/typedom/color/CSSHWB.cpp
    M Source/WebCore/css/typedom/color/CSSHWB.h
    M Source/WebCore/css/typedom/color/CSSLCH.cpp
    M Source/WebCore/css/typedom/color/CSSLCH.h
    M Source/WebCore/css/typedom/color/CSSLab.cpp
    M Source/WebCore/css/typedom/color/CSSLab.h
    M Source/WebCore/css/typedom/color/CSSOKLCH.cpp
    M Source/WebCore/css/typedom/color/CSSOKLCH.h
    M Source/WebCore/css/typedom/color/CSSOKLab.cpp
    M Source/WebCore/css/typedom/color/CSSOKLab.h
    M Source/WebCore/css/typedom/color/CSSRGB.h

  Log Message:
  -----------
  Implement input validation for CSSColorValues
https://bugs.webkit.org/show_bug.cgi?id=247167

Reviewed by Antti Koivisto.

Implement input validation for CSSColorValues:
- https://drafts.css-houdini.org/css-typed-om/#csshsl
- https://drafts.css-houdini.org/css-typed-om/#csshwb
- https://drafts.css-houdini.org/css-typed-om/#csslab
- https://drafts.css-houdini.org/css-typed-om/#csslch
- https://drafts.css-houdini.org/css-typed-om/#cssoklab
- https://drafts.css-houdini.org/css-typed-om/#cssoklch

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/resources/testhelper.js:
(assert_color_channel_approx_equals):
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHSL.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssHWB.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLCH.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssLab.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLCH.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssOKLab.html: Added.
* Source/WebCore/css/typedom/color/CSSColorValue.cpp:
(WebCore::CSSColorValue::rectifyCSSColorAngle):
(WebCore::CSSColorValue::rectifyCSSColorNumber):
(WebCore::CSSColorValue::toCSSColorPercent):
(WebCore::CSSColorValue::toCSSColorAngle):
(WebCore::CSSColorValue::toCSSColorNumber):
* Source/WebCore/css/typedom/color/CSSColorValue.h:
* Source/WebCore/css/typedom/color/CSSHSL.cpp:
(WebCore::CSSHSL::create):
(WebCore::CSSHSL::CSSHSL):
(WebCore::CSSHSL::h const):
(WebCore::CSSHSL::setH):
(WebCore::CSSHSL::s const):
(WebCore::CSSHSL::setS):
(WebCore::CSSHSL::l const):
(WebCore::CSSHSL::setL):
(WebCore::CSSHSL::alpha const):
(WebCore::CSSHSL::setAlpha):
* Source/WebCore/css/typedom/color/CSSHSL.h:
(WebCore::CSSHSL::create): Deleted.
(WebCore::CSSHSL::h const): Deleted.
(WebCore::CSSHSL::setH): Deleted.
(WebCore::CSSHSL::s const): Deleted.
(WebCore::CSSHSL::setS): Deleted.
(WebCore::CSSHSL::l const): Deleted.
(WebCore::CSSHSL::setL): Deleted.
(WebCore::CSSHSL::alpha const): Deleted.
(WebCore::CSSHSL::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSHWB.cpp:
(WebCore::CSSHWB::create):
(WebCore::CSSHWB::CSSHWB):
(WebCore::CSSHWB::h const):
(WebCore::CSSHWB::setH):
(WebCore::CSSHWB::w const):
(WebCore::CSSHWB::setW):
(WebCore::CSSHWB::b const):
(WebCore::CSSHWB::setB):
(WebCore::CSSHWB::alpha const):
(WebCore::CSSHWB::setAlpha):
* Source/WebCore/css/typedom/color/CSSHWB.h:
(WebCore::CSSHWB::create): Deleted.
(WebCore::CSSHWB::h const): Deleted.
(WebCore::CSSHWB::setH): Deleted.
(WebCore::CSSHWB::w const): Deleted.
(WebCore::CSSHWB::setW): Deleted.
(WebCore::CSSHWB::b const): Deleted.
(WebCore::CSSHWB::setB): Deleted.
(WebCore::CSSHWB::alpha const): Deleted.
(WebCore::CSSHWB::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSLCH.cpp:
(WebCore::CSSLCH::create):
(WebCore::CSSLCH::CSSLCH):
(WebCore::CSSLCH::l const):
(WebCore::CSSLCH::setL):
(WebCore::CSSLCH::c const):
(WebCore::CSSLCH::setC):
(WebCore::CSSLCH::h const):
(WebCore::CSSLCH::setH):
(WebCore::CSSLCH::alpha const):
(WebCore::CSSLCH::setAlpha):
* Source/WebCore/css/typedom/color/CSSLCH.h:
(WebCore::CSSLCH::create): Deleted.
(WebCore::CSSLCH::l const): Deleted.
(WebCore::CSSLCH::setL): Deleted.
(WebCore::CSSLCH::c const): Deleted.
(WebCore::CSSLCH::setC): Deleted.
(WebCore::CSSLCH::h const): Deleted.
(WebCore::CSSLCH::setH): Deleted.
(WebCore::CSSLCH::alpha const): Deleted.
(WebCore::CSSLCH::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSLab.cpp:
(WebCore::CSSLab::create):
(WebCore::CSSLab::CSSLab):
(WebCore::CSSLab::l const):
(WebCore::CSSLab::setL):
(WebCore::CSSLab::a const):
(WebCore::CSSLab::setA):
(WebCore::CSSLab::b const):
(WebCore::CSSLab::setB):
(WebCore::CSSLab::alpha const):
(WebCore::CSSLab::setAlpha):
* Source/WebCore/css/typedom/color/CSSLab.h:
(WebCore::CSSLab::create): Deleted.
(WebCore::CSSLab::l const): Deleted.
(WebCore::CSSLab::setL): Deleted.
(WebCore::CSSLab::a const): Deleted.
(WebCore::CSSLab::setA): Deleted.
(WebCore::CSSLab::b const): Deleted.
(WebCore::CSSLab::setB): Deleted.
(WebCore::CSSLab::alpha const): Deleted.
(WebCore::CSSLab::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSOKLCH.cpp:
(WebCore::CSSOKLCH::create):
(WebCore::CSSOKLCH::CSSOKLCH):
(WebCore::CSSOKLCH::l const):
(WebCore::CSSOKLCH::setL):
(WebCore::CSSOKLCH::c const):
(WebCore::CSSOKLCH::setC):
(WebCore::CSSOKLCH::h const):
(WebCore::CSSOKLCH::setH):
(WebCore::CSSOKLCH::alpha const):
(WebCore::CSSOKLCH::setAlpha):
* Source/WebCore/css/typedom/color/CSSOKLCH.h:
(WebCore::CSSOKLCH::create): Deleted.
(WebCore::CSSOKLCH::l const): Deleted.
(WebCore::CSSOKLCH::setL): Deleted.
(WebCore::CSSOKLCH::c const): Deleted.
(WebCore::CSSOKLCH::setC): Deleted.
(WebCore::CSSOKLCH::h const): Deleted.
(WebCore::CSSOKLCH::setH): Deleted.
(WebCore::CSSOKLCH::alpha const): Deleted.
(WebCore::CSSOKLCH::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSOKLab.cpp:
(WebCore::CSSOKLab::create):
(WebCore::CSSOKLab::CSSOKLab):
(WebCore::CSSOKLab::l const):
(WebCore::CSSOKLab::setL):
(WebCore::CSSOKLab::a const):
(WebCore::CSSOKLab::setA):
(WebCore::CSSOKLab::b const):
(WebCore::CSSOKLab::setB):
(WebCore::CSSOKLab::alpha const):
(WebCore::CSSOKLab::setAlpha):
* Source/WebCore/css/typedom/color/CSSOKLab.h:
(WebCore::CSSOKLab::create): Deleted.
(WebCore::CSSOKLab::l const): Deleted.
(WebCore::CSSOKLab::setL): Deleted.
(WebCore::CSSOKLab::a const): Deleted.
(WebCore::CSSOKLab::setA): Deleted.
(WebCore::CSSOKLab::b const): Deleted.
(WebCore::CSSOKLab::setB): Deleted.
(WebCore::CSSOKLab::alpha const): Deleted.
(WebCore::CSSOKLab::setAlpha): Deleted.
* Source/WebCore/css/typedom/color/CSSRGB.h:

Canonical link: https://commits.webkit.org/256229@main

More information about the webkit-changes mailing list