[webkit-changes] [WebKit/WebKit] e5e73c: [MSE] Bring back some useful SourceBuffer logs

Enrique Ocaña González noreply at github.com
Wed Nov 2 03:50:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5e73c6cc13de7853fde82bf4db544153af1eb7f
      https://github.com/WebKit/WebKit/commit/e5e73c6cc13de7853fde82bf4db544153af1eb7f
  Author: Enrique Ocaña González <eocanha at igalia.com>
  Date:   2022-11-02 (Wed, 02 Nov 2022)

  Changed paths:
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp

  Log Message:
  -----------
  [MSE] Bring back some useful SourceBuffer logs
https://bugs.webkit.org/show_bug.cgi?id=247122

Reviewed by Xabier Rodriguez-Calvar.

Changeset https://trac.webkit.org/changeset/241148/webkit from
https://bugs.webkit.org/show_bug.cgi?id=194348 removed line
https://github.com/WebKit/WebKit/commit/cd4e7ebee1a6aaa956534cb8709d95ec2c75b85a#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710
, which was very useful when debugging MSE append problems.

This patch is bringing that line back and adding a similar one
to appendBufferInternal(), which will be helpful to track how
the buffered ranges evolve as the append is processed.

Original author: Pawel Lampe <pawel.lampe at gmail.com>
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/955

* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal): Added log line.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto.

Canonical link: https://commits.webkit.org/256224@main




More information about the webkit-changes mailing list