[webkit-changes] [WebKit/WebKit] d8123a: Simplify MiniBrowser settings menu construction

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8123acbf6c2d2ce59a59c6098c6dbf0f8201939
      https://github.com/WebKit/WebKit/commit/d8123acbf6c2d2ce59a59c6098c6dbf0f8201939
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M Tools/MiniBrowser/mac/SettingsController.m

  Log Message:
  -----------
  Simplify MiniBrowser settings menu construction
https://bugs.webkit.org/show_bug.cgi?id=247305

Reviewed by Simon Fraser.

* Tools/MiniBrowser/mac/SettingsController.m:
(-[SettingsController initWithMenu:]):
(addItemToMenuWithTarget):
(addSeparatorToMenu):
(addSubmenuToMenu):
(-[SettingsController _populateMenu:]):
(-[SettingsController buildUserAgentsMenu:]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController changeCustomUserAgent:]):
(-[SettingsController dealloc]): Deleted.
(-[SettingsController _addItemWithTitle:action:indented:]): Deleted.
(-[SettingsController _addHeaderWithTitle:]): Deleted.
(-[SettingsController _populateMenu]): Deleted.
(-[SettingsController changeCutomUserAgent:]): Deleted.
Simplify the menu construction with some more helper functions.
Move the resource usage overlays into the overlay submenu.
Remove the empty WebKit1-only settings section.
Fix some typos.

Canonical link: https://commits.webkit.org/256195@main