[webkit-changes] [WebKit/WebKit] fe7889: Use the correct paint methods for painting a secti...
Ahmad Saleem
noreply at github.com
Tue Nov 1 11:34:59 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fe7889ca7da926d131e576beed57733828295b82
https://github.com/WebKit/WebKit/commit/fe7889ca7da926d131e576beed57733828295b82
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2022-11-01 (Tue, 01 Nov 2022)
Changed paths:
A LayoutTests/editing/selection/iframe-select-expected.html
A LayoutTests/editing/selection/iframe-select.html
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderWidget.cpp
Log Message:
-----------
Use the correct paint methods for painting a section rect of RenderWidgets
Use the correct paint methods for painting a section rect of RenderWidgets
https://bugs.webkit.org/show_bug.cgi?id=246939
Reviewed by Simon Fraser.
Merge - https://src.chromium.org/viewvc/blink?revision=181068&view=revision
Previously, it was using a paint invalidation method. That is less
efficient, and also wrong if the renderer is a squashed layer.
* Source/WebCore/rendering/RenderElement.h: Update "paint" function to to have "paintOffset" and also add comment for explanation
* Source/WebCore/rendering/RenderObject.h: Update Comment and remove "selectionRect" function
* Source/WebCore/rendering/RenderWidget.cpp: Fix paint logic for selected widgets and remove "FIXME" about selectionRect
* LayoutTests/editing/selection/iframe-select.html: Added Test Case
* LayoutTests/editing/selection/iframe-select-expected.html: Added Test Case Expectations
Canonical link: https://commits.webkit.org/256191@main
More information about the webkit-changes
mailing list