[webkit-changes] [WebKit/WebKit] f6816a: Regression(iOS 16.1) Use of Shared Workers cause W...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6816a3f3c663bf5d0e6ed9e9c6f91a6943aa272
      https://github.com/WebKit/WebKit/commit/f6816a3f3c663bf5d0e6ed9e9c6f91a6943aa272
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M LayoutTests/http/tests/navigation/resources/shared-worker-script.js
    A LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled-expected.txt
    A LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/workers/WorkerScriptLoader.cpp
    M Source/WebCore/workers/WorkerScriptLoader.h

  Log Message:
  -----------
  Regression(iOS 16.1) Use of Shared Workers cause Web Content process crash in non-default-browser WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=247147
rdar://101562445

Reviewed by Geoffrey Garen.

253592 at main made the initialization of WorkerScriptLoader::m_clientIdentifier
conditional on service workers being enabled. However, this wasn't correct
since shared workers rely on this data member too.

This clientIdentifier gets sent over IPC at some point and fails decoding
when not initialized, leading to the WebProcess getting killed.

* LayoutTests/http/tests/navigation/resources/shared-worker-script.js:
(self.onconnect):
* LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled-expected.txt: Added.
* LayoutTests/http/tests/workers/shared/shared-worker-with-service-workers-disabled.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::~WorkerScriptLoader):
(WebCore::WorkerScriptLoader::loadAsynchronously):
* Source/WebCore/workers/WorkerScriptLoader.h:

Canonical link: https://commits.webkit.org/256185@main