[webkit-changes] [WebKit/WebKit] c2f1bd: "<CATransformLayer> changing property contentsScal...

Simon Fraser noreply at github.com
Fri Dec 30 16:03:40 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2f1bd3f763bca4b4b769f0dad4334ec28a25832
      https://github.com/WebKit/WebKit/commit/c2f1bd3f763bca4b4b769f0dad4334ec28a25832
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-12-30 (Fri, 30 Dec 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

  Log Message:
  -----------
  "<CATransformLayer> changing property contentsScale in transform-only layer, will have no effect" logging
https://bugs.webkit.org/show_bug.cgi?id=249946
rdar://103762578

Reviewed by Tim Horton.

In 253606 at main I made it possible for the primary layer of a GraphicsLayer to be a CATransformLayer.
However, we had existing code that unconditionally cause -contentsScale and -rasterizationScale to
be set on all CALayers, and these don't make sense on a CATransformLayer, which never has painted
content.

So conditionalize calling `noteLayerPropertyChanged(ContentsScaleChanged)` to only happen on
non-transform layers.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::initialize):

Canonical link: https://commits.webkit.org/258364@main




More information about the webkit-changes mailing list