[webkit-changes] [WebKit/WebKit] c26a65: Remove CSSKeyframesRule.insertRule()

Karl Dubost noreply at github.com
Fri Dec 30 03:16:13 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c26a65e62e3999f70665e1aaa493acc9938891ae
      https://github.com/WebKit/WebKit/commit/c26a65e62e3999f70665e1aaa493acc9938891ae
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-30 (Fri, 30 Dec 2022)

  Changed paths:
    M LayoutTests/animations/CSSKeyframesRule-parameters-expected.txt
    M LayoutTests/animations/CSSKeyframesRule-parameters.html
    M LayoutTests/animations/change-keyframes-expected.txt
    M LayoutTests/animations/change-keyframes.html
    M LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js
    M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
    M Source/WebCore/css/CSSKeyframesRule.cpp
    M Source/WebCore/css/CSSKeyframesRule.h
    M Source/WebCore/css/CSSKeyframesRule.idl

  Log Message:
  -----------
  Remove CSSKeyframesRule.insertRule()
https://bugs.webkit.org/show_bug.cgi?id=247364
rdar://102141002

Reviewed by Antoine Quint.

Removes insertRule. It was removed from Gecko, 10 years ago.
https://bugzilla.mozilla.org/show_bug.cgi?id=841896
It was first deprecated in Blink and removed from Blink 7 years ago.
https://groups.google.com/a/chromium.org/g/blink-dev/c/wW7w8Hro78s/m/JDULF2oM9iIJ
GitHub Search doesn't return meaningful instances of insertRule.

* LayoutTests/animations/change-keyframes-expected.txt:
* LayoutTests/animations/change-keyframes.html:
* LayoutTests/animations/CSSKeyframesRule-parameters-expected.txt:
* LayoutTests/animations/CSSKeyframesRule-parameters.html:
* LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js:
(executeTests):
* LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
* Source/WebCore/css/CSSKeyframesRule.cpp:
(WebCore::CSSKeyframesRule::insertRule): Deleted.
* Source/WebCore/css/CSSKeyframesRule.h:
* Source/WebCore/css/CSSKeyframesRule.idl:

Canonical link: https://commits.webkit.org/258361@main




More information about the webkit-changes mailing list