[webkit-changes] [WebKit/WebKit] ab848f: [IFC][bidi] "unicode-bidi: plaintext" lets us igno...
Alan Baradlay
noreply at github.com
Wed Dec 28 10:17:21 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ab848ffdaca3262f735913a399fc23df8846f337
https://github.com/WebKit/WebKit/commit/ab848ffdaca3262f735913a399fc23df8846f337
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-12-28 (Wed, 28 Dec 2022)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h
Log Message:
-----------
[IFC][bidi] "unicode-bidi: plaintext" lets us ignore the root's directionality
https://bugs.webkit.org/show_bug.cgi?id=249917
Reviewed by Antti Koivisto.
Let's compute the inline direction by calling ubidi_getBaseDirection when unicode-bidi is plaintext and the content does not trigger visual reordering otherwise.
https://w3c.github.io/csswg-drafts/css-writing-modes/#unicode-bidi
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::InlineItemsBuilder):
(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxStart):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxEnd):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h:
(WebCore::Layout::InlineItemsBuilder::contentRequiresVisualReordering const):
(WebCore::Layout::InlineItemsBuilder::needsVisualReordering const): Deleted.
Canonical link: https://commits.webkit.org/258348@main
More information about the webkit-changes
mailing list