[webkit-changes] [WebKit/WebKit] 21c66f: [css-ui] Fix box-sizing web platform test failures

Karl Dubost noreply at github.com
Tue Dec 27 09:52:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21c66fcd81750f21944d2057c20c00d2633011b6
      https://github.com/WebKit/WebKit/commit/21c66fcd81750f21944d2057c20c00d2633011b6
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-27 (Tue, 27 Dec 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/css2.1/20110323/replaced-intrinsic-003.htm
    R LayoutTests/css2.1/20110323/resources/replaced-intrinsic-003.svg
    M LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-replaced-minmax-expected.txt
    R LayoutTests/platform/glib/css2.1/20110323/replaced-intrinsic-003-expected.txt
    R LayoutTests/platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png
    R LayoutTests/platform/gtk/svg/hixie/intrinsic/003-expected.png
    R LayoutTests/platform/gtk/svg/hixie/intrinsic/003-expected.txt
    M LayoutTests/platform/ios-wk2/TestExpectations
    R LayoutTests/platform/ios-wk2/svg/hixie/intrinsic/003-expected.png
    M LayoutTests/platform/ios/TestExpectations
    R LayoutTests/platform/ios/css2.1/20110323/replaced-intrinsic-003-expected.txt
    R LayoutTests/platform/ios/svg/hixie/intrinsic/003-expected.txt
    R LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/hixie/intrinsic/003-expected.txt
    R LayoutTests/platform/mac-ventura-wk2-pixel/svg/hixie/intrinsic/003-expected.png
    M LayoutTests/platform/mac-wk1/TestExpectations
    R LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png
    R LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt
    R LayoutTests/platform/mac/svg/hixie/intrinsic/003-expected.png
    R LayoutTests/platform/mac/svg/hixie/intrinsic/003-expected.txt
    M LayoutTests/platform/win/TestExpectations
    R LayoutTests/platform/win/css2.1/20110323/replaced-intrinsic-003-expected.txt
    R LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.png
    R LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt
    R LayoutTests/platform/wincairo/css2.1/20110323/replaced-intrinsic-003-expected.txt
    R LayoutTests/platform/wincairo/svg/hixie/intrinsic/003-expected.txt
    R LayoutTests/platform/wpe/svg/hixie/intrinsic/003-expected.txt
    R LayoutTests/svg/hixie/intrinsic/003.html
    R LayoutTests/svg/hixie/intrinsic/resources/003.svg
    M Source/WebCore/rendering/RenderReplaced.cpp

  Log Message:
  -----------
  [css-ui] Fix box-sizing web platform test failures
https://bugs.webkit.org/show_bug.cgi?id=175287
rdar://103700285

Reviewed by Tim Nguyen.

This fixes the logicalWidth computation in RenderReplaced according
to the equation described in the CSS 2.2 specification
https://www.w3.org/TR/CSS22/visudet.html#blockwidth

This also removes two tests and their expectations from the tree
which are covered by WPT tests and have also been removed
from the blink codebase. That would fix
https://bugs.webkit.org/show_bug.cgi?id=228211

* LayoutTests/css2.1/20110323/replaced-intrinsic-003.htm: Removed.
* LayoutTests/css2.1/20110323/resources/replaced-intrinsic-003.svg: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-replaced-minmax-expected.txt:
* LayoutTests/platform/glib/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
* LayoutTests/platform/gtk/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
* LayoutTests/platform/gtk/svg/hixie/intrinsic/003-expected.png: Removed.
* LayoutTests/platform/gtk/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/ios-wk2/svg/hixie/intrinsic/003-expected.png: Removed.
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
* LayoutTests/platform/ios/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/mac-ventura-wk2-pixel/svg/hixie/intrinsic/003-expected.png: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png: Removed.
* LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
* LayoutTests/platform/mac/svg/hixie/intrinsic/003-expected.png: Removed.
* LayoutTests/platform/mac/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/win/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
* LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.png: Removed.
* LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/win/TestExpectations:
* LayoutTests/platform/wincairo/css2.1/20110323/replaced-intrinsic-003-expected.txt: Removed.
* LayoutTests/platform/wincairo/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/platform/wpe/svg/hixie/intrinsic/003-expected.txt: Removed.
* LayoutTests/svg/hixie/intrinsic/003.html: Removed.
* LayoutTests/svg/hixie/intrinsic/resources/003.svg: Removed.
* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeConstrainedLogicalWidth const):

Canonical link: https://commits.webkit.org/258342@main




More information about the webkit-changes mailing list