[webkit-changes] [WebKit/WebKit] ed0877: AirDisassembler: don't crash when we don't get eno...

aoikonomopoulos noreply at github.com
Mon Dec 26 02:55:58 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed087739e18c9013cbe3d0b16d14967ec6a809fe
      https://github.com/WebKit/WebKit/commit/ed087739e18c9013cbe3d0b16d14967ec6a809fe
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2022-12-26 (Mon, 26 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/b3/B3Value.cpp

  Log Message:
  -----------
  AirDisassembler: don't crash when we don't get enough frames
https://bugs.webkit.org/show_bug.cgi?id=249842

Reviewed by Justin Michaud.

Value::generateCompilerConstructionSite assumes we'll get enough frames
that it's safe to skip framesToPrint of them. However, backtrace() is
not guaranteed to work reliably on all platforms. E.g. we occasionally
get zero frames on ARM. Only skip past if backtrace()
returned >framesToSkip frames.

* Source/JavaScriptCore/b3/B3Value.cpp:
(JSC::B3::Value::generateCompilerConstructionSite):

Canonical link: https://commits.webkit.org/258334@main




More information about the webkit-changes mailing list