[webkit-changes] [WebKit/WebKit] 998885: [WinCairo] Get cap-height font metrics for initial...

Fujii Hironori noreply at github.com
Sat Dec 24 04:48:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9988857494584a66ab95347b695a556315f5eff4
      https://github.com/WebKit/WebKit/commit/9988857494584a66ab95347b695a556315f5eff4
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-12-24 (Sat, 24 Dec 2022)

  Changed paths:
    M LayoutTests/platform/wincairo/TestExpectations
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-basic-expected.txt
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-border-padding-expected.txt
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-clearance-expected.txt
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-descender-expected.txt
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-raised-expected.txt
    M LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-sunken-expected.txt
    M Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp

  Log Message:
  -----------
  [WinCairo] Get cap-height font metrics for initial-letter support
https://bugs.webkit.org/show_bug.cgi?id=249830

Reviewed by Don Olmstead.

-webkit-initial-letter didn't work because capHeight wasn't set to
FontMetrics. The legacy win32 API doesn't have a API to get capHeight.
Assuming (tmAscent - tmInternalLeading) is capHeight.

* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-basic-expected.txt:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-border-padding-expected.txt:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-clearance-expected.txt:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-descender-expected.txt:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-raised-expected.txt:
* LayoutTests/platform/wincairo/fast/css-generated-content/initial-letter-sunken-expected.txt:
* Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::Font::platformInit):

Canonical link: https://commits.webkit.org/258319@main




More information about the webkit-changes mailing list