[webkit-changes] [WebKit/WebKit] 6a6997: [IFC][hanging punctuation] Line::HangingContent sh...
Alan Baradlay
noreply at github.com
Thu Dec 22 21:09:18 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a6997c658c6ff0e980441af249c967910745b39
https://github.com/WebKit/WebKit/commit/6a6997c658c6ff0e980441af249c967910745b39
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-12-22 (Thu, 22 Dec 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
Log Message:
-----------
[IFC][hanging punctuation] Line::HangingContent should tell if the trailing content is conditionally hanging
https://bugs.webkit.org/show_bug.cgi?id=249713
Reviewed by Antti Koivisto.
"Stop or Comma" trailing content is conditionally hanging when hanging-punctuation is set to allow-end. However it is non-conditional when hanging-punctuation says "force-end".
In this patch, we start tracking if the trailing hanging content is conditional or not so that we can reset/trim them accordingly.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::handleTrailingHangingContent):
(WebCore::Layout::Line::appendTextContent):
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::HangingContent::resetTrailingContent):
(WebCore::Layout::Line::HangingContent::isTrailingContentPunctuation const):
(WebCore::Layout::Line::HangingContent::isTrailingContentConditional const):
(WebCore::Layout::Line::HangingContent::isTrailingContentConditionalWhenFollowedByForcedLineBreak const):
(WebCore::Layout::Line::HangingContent::setTrailingPunctuation):
(WebCore::Layout::Line::HangingContent::setTrailingStopOrComma):
(WebCore::Layout::Line::HangingContent::setTrailingWhitespace):
(WebCore::Layout::Line::HangingContent::isTrailingContentWhitespace const): Deleted.
(WebCore::Layout::Line::HangingContent::isTrailingContentStopOrComma const): Deleted.
(WebCore::Layout::Line::HangingContent::trailingWhitespaceWidth const): Deleted.
(WebCore::Layout::Line::HangingContent::resetTrailingPunctuation): Deleted.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::hasHangableStopOrCommaEnd):
Canonical link: https://commits.webkit.org/258281@main
More information about the webkit-changes
mailing list