[webkit-changes] [WebKit/WebKit] 1446ba: gdesktopappinfo.h not excluded on macOS

Michael Catanzaro noreply at github.com
Thu Dec 22 14:29:29 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1446ba237462e1c5fcbe2cedd92c4ea8ac6bb4a6
      https://github.com/WebKit/WebKit/commit/1446ba237462e1c5fcbe2cedd92c4ea8ac6bb4a6
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp

  Log Message:
  -----------
  gdesktopappinfo.h not excluded on macOS
https://bugs.webkit.org/show_bug.cgi?id=248727

Reviewed by Carlos Garcia Campos.

Although macOS has most of the gio-unix-2.0 functionality, this
particular header is an exception and just needs to be handled
specially.

MacPorts has a patch to sometimes build with GDesktopAppInfo enabled, so
it's best to just detect the presence of the header instead of trying to
enable this code on OS(UNIX_BUT_NOT_MACOS_EXCEPT_SOMETIMES).

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp:
(WebKit::applicationIcon):

Canonical link: https://commits.webkit.org/258260@main




More information about the webkit-changes mailing list