[webkit-changes] [WebKit/WebKit] 90f1d3: Use WeakHashSet<ScrollableArea> instead of HashSet...

Nikos Mouchtaris noreply at github.com
Thu Dec 22 12:02:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90f1d32abbcef785e1ae4b21fa131346c87f2fb1
      https://github.com/WebKit/WebKit/commit/90f1d32abbcef785e1ae4b21fa131346c87f2fb1
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/page/FocusController.cpp
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/FrameView.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
    M Source/WebCore/platform/ScrollableArea.cpp
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Use WeakHashSet<ScrollableArea> instead of HashSet<ScrollableArea*>
https://bugs.webkit.org/show_bug.cgi?id=249428
rdar://103418459

Reviewed by Ryosuke Niwa.

Use WeakHashSet<ScrollableArea> instead of HashSet<ScrollableArea*>.
Make ScrollableArea compatible with CheckedPtr.

* Source/WebCore/dom/Document.cpp:
(WebCore::serviceScrollAnimationForScrollableArea):
(WebCore::Document::runScrollSteps):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setIsVisibleAndActiveInternal):
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::invalidateScrollbarsForAllScrollableAreas):
(WebCore::FrameView::notifyScrollableAreasThatContentAreaWillPaint const):
(WebCore::FrameView::addScrollableAreaForAnimatedScroll):
(WebCore::FrameView::removeScrollableAreaForAnimatedScroll):
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea const):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::lockAllOverlayScrollbarsToHidden):
(WebCore::Page::stopKeyboardScrollAnimation):
* Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
* Source/WebCore/platform/ScrollableArea.cpp:
* Source/WebCore/platform/ScrollableArea.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::numberOfScrollableAreas):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::pageContainsAnyHorizontalScrollbars):

Canonical link: https://commits.webkit.org/258255@main




More information about the webkit-changes mailing list