[webkit-changes] [WebKit/WebKit] c98286: ASSERTION FAILED: rangesIntersect(m_renderer->logi...

Fujii Hironori noreply at github.com
Thu Dec 22 06:31:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c982868aec771bd6f4bc630eed135b202ba9b328
      https://github.com/WebKit/WebKit/commit/c982868aec771bd6f4bc630eed135b202ba9b328
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M Source/WebCore/rendering/FloatingObjects.cpp

  Log Message:
  -----------
  ASSERTION FAILED: rangesIntersect(m_renderer->logicalTopForFloat(floatingObject), m_renderer->logicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom)
https://bugs.webkit.org/show_bug.cgi?id=249571

Reviewed by Darin Adler.

m_placedFloatsTree of FloatingObjects class is a red-black tree that
is ordering floating objects with their logical top and bottom
interval. It truncates fractional part when adding a new interval due
to a certain reason (bug#125831).

However, two assertions in this class didn't take the truncation into
account. The logical top and bottom in the assertions should be
truncated.

* Source/WebCore/rendering/FloatingObjects.cpp:
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::intervalForFloatingObject):
(WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded):

Canonical link: https://commits.webkit.org/258241@main




More information about the webkit-changes mailing list